Stop velocity tracking on touch cancel #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I tested with multiple fingers and note our current support only works for single finger events. If we want scrolling with multiple fingers, we should file an additional ticket. |
|
LGTM |
inlinestyle
added a commit
to SeamlessDocsDev/seamlessng__3rdparty__facebook__fixed-data-table
that referenced
this pull request
Jul 21, 2016
Summary: Manually brings in these two PRs from github.com/schrodinger/fixed-data-table-2: - schrodinger/fixed-data-table-2#7 - schrodinger/fixed-data-table-2#19 Also - pins React to 15.1.0 Test Plan: Manual, tested in Chrome mobile emulator so far, will test on multiple devices to see if there's improvement Reviewers: jose, Hsin, yongxu Reviewed By: Hsin, yongxu Differential Revision: http://code.seamlessdocs.com/D969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop velocity tracking on touch cancel
Description
Add a handler so onTouchCancel we clear the interval used for tracking velocity.
Motivation and Context
Prevents wasted CPU cycles when a drag is cancelled
How Has This Been Tested?
Tested in sandbox in chrome on Galaxy S5
Screenshots (if appropriate):
Types of changes
Checklist: