Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing setting scrollLeft not firing callback #54

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Fixing setting scrollLeft not firing callback #54

merged 1 commit into from
Sep 29, 2016

Conversation

KamranAsif
Copy link
Contributor

Description

onScrollEnd/onScrollStart callbacks weren't firing when scrollLeft is set manually by the user.
_didScrollStop was being called, but _.isScrolling flag wasn't set. This is because _didScrollStart wasn't fired on initial call.

Motivation and Context

#53

How Has This Been Tested?

https://jsfiddle.net/nprp19me/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@wcjordan
Copy link
Member

lgtm

@KamranAsif KamranAsif merged commit 9a477a9 into master Sep 29, 2016
@KamranAsif KamranAsif deleted the FDT-53 branch September 29, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants