Fix #661 #662
Closed
Fix #661 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeepnschrodinger
requested review from
AmanGupta2708,
karry08,
mycrobe and
novakps
|
@grassick , thanks for setting up a PR so quick! Since the bug described here is present on I also wanna give a heads up that the code around setting up refs and lifecycle methods have been slightly refactored due to the changes in #657, but the fix should essentially be the same. |
pradeepnschrodinger
requested changes
Dec 3, 2022
|
@pradeepnschrodinger Closing for #662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a surgical fix for #661. I've tested it, it works, and the change is tiny!