Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DomValidator bug #169

Merged
merged 3 commits into from
Feb 8, 2024
Merged

fix: DomValidator bug #169

merged 3 commits into from
Feb 8, 2024

Conversation

siesdart
Copy link
Contributor

Description

Fixed a bug where Invalid argument(s): "xxxx" is not a valid attribute name. error would appear for attributes with capital letters in the middle of name, such as 'viewBox' in svg.

Type of Change

  • ❌ Breaking change
  • ✨ New feature or improvement
  • 🛠️ Bug fix
  • 🧹 Code refactor
  • 📝 Documentation
  • 🗑️ Chore

Ready Checklist

  • I've read the Contribution Guide.
  • In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
    the semantic_changelog format.
  • I updated/added relevant documentation (doc comments with ///).
  • I added myself to the AUTHORS file (optional, if you want to).

If you need help, consider asking for advice on the #contribute channel on Discord.

Copy link

Package Version Report

The following packages have been updated:
jaspr : 0.10.0 -> 0.10.1
jaspr_builder : 0.10.0 -> 0.10.1
jaspr_cli : 0.10.0 -> 0.10.1
jaspr_test : 0.10.0 -> 0.10.1

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fdd5f2) 61.52% compared to head (dbe96ea) 61.52%.
Report is 8 commits behind head on main.

❗ Current head dbe96ea differs from pull request most recent head da0103f. Consider uploading reports for the commit da0103f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   61.52%   61.52%           
=======================================
  Files          95       95           
  Lines        4052     4052           
=======================================
  Hits         2493     2493           
  Misses       1559     1559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schultek
Copy link
Owner

schultek commented Feb 8, 2024

Thanks.

@schultek schultek merged commit 7b17dbe into schultek:main Feb 8, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants