Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minify option to tailwind #247

Merged
merged 4 commits into from
Jul 13, 2024
Merged

add minify option to tailwind #247

merged 4 commits into from
Jul 13, 2024

Conversation

siesdart
Copy link
Contributor

Description

Currently in jaspr_tailwind CSS is compiled without any compression. I feel this part is not very desirable for production. Therefore, I tried adding the --minify option to the CLI so that tailwind undergoes a minification process when compiling CSS. Also, in this pull request, the --minify option was simply added, but I think it would be good to add it only when jaspr build, so I am suggesting this.

Type of Change

  • ✨ New feature or improvement

Ready Checklist

  • I've read the Contribution Guide.
  • In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
    the semantic_changelog format.
  • I updated/added relevant documentation (doc comments with ///).
  • I added myself to the AUTHORS file (optional, if you want to).

@siesdart siesdart requested a review from schultek as a code owner June 25, 2024 15:59
Copy link

Package Version Report

The following packages have been updated:
jaspr_tailwind : 0.2.0 -> 0.2.1

@schultek
Copy link
Owner

As you said, there should be a check to only add this in release mode.

@siesdart
Copy link
Contributor Author

I fixed it to only apply in release mode as you said, thank you.

Copy link
Owner

@schultek schultek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@schultek schultek merged commit 89b316a into schultek:main Jul 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants