Fix setting the default log level to WARN #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 76150f0, we used `with_max_level()` to set the default log level but apparently the behaviour changed in the meantime (or we didn't test it correctly back then). The documentation of `with_env_filter` [0] states: > If a filter was previously set, or a maximum level was set by the with_max_level method, that value is replaced by the new filter. The idea in 76150f0 was that `with_env_filter` would only override the default from `with_max_level` if the `$RUST_LOG` environment variable is set but the `EnvFilter::from_default_env()` also had a default log level (unfortunately it defaults to ERROR instead of WARN). We now replace `from_default_env()` with the underlying code [1] but changed the default log level from ERROR to WARN. [0]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/fmt/struct.SubscriberBuilder.html#method.with_env_filter [1]: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html#method.from_default_env Signed-off-by: Michael Weiss <michael.weiss@atos.net> Co-authored-by: Nico Steinle <nico.steinle@atos.net>
It was only used in `src/main.rs` and we can or rather should use the `tracing` crate instead for consistency. We switched to `tracing` (Tokio) in ff5666c and don't need the direct dependency on `log` (it will still get pulled in transitively through other dependencies though). Signed-off-by: Michael Weiss <michael.weiss@atos.net>
Merged
via the queue into
science-computing:master
with commit Oct 19, 2023
cea2d8b
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 76150f0, we used
with_max_level()to set the default log level but apparently the behaviour changed in the meantime (or we didn't test it correctly back then). The documentation ofwith_env_filter0 states:The idea in 76150f0 was that
with_env_filterwould only override the default fromwith_max_levelif the$RUST_LOGenvironment variable is set but theEnvFilter::from_default_env()also had a default log level (unfortunately it defaults to ERROR instead of WARN). We now replacefrom_default_env()with the underlying code 1 but changed the default log level from ERROR to WARN.