Add optional tracing-chrome setup #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds an optional flag `--tracing-chrome` which enables the tracing-chrome backend for traces which then generates a chrome://tracing compatible file. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
primeos-work
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Cool, thanks a lot! ❤️ :)
I tested it together with #361 and the results look fine - I'll need to take a closer look though as I'm not that familiar with tracing yet.
Unfortunately I'm likely unavailable next week but I'll try to properly review and merge both PRs within the next two weeks (this one should definitely be good to go).
|
Sorry for the additional delay... - I had to fix some unrelated CI regressions first and got caught up with some other stuff. Thanks again for your PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an optional flag
--tracing-chromewhich enables the tracing-chrome backend for traces which then generates a chrome://tracing compatible file.Please check whether this works as desired before merging.