Fix the error propagation of the "source download" command #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional source verification in 2f8034b introduced a regression by returning the source verification errors before the errors of the download operation (the download errors therefore get omitted and users get misleading errors that the sources are missing and that the verification did therefore fail).
This restores the proper error messages and avoids unnecessary source verification by returning errors of the download operation before triggering the verification.
We also don't need the debug output as we already return the errors and I've put
Ok(())
at the end to make it a bit more readable.Before:
After: