fileselector: divided to header,body, and footer. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when changing dir, only the body got replaced. This way the widget will stay in the same place. otherwise the widget always goes to the end of all widgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug that @JeanBilheux found: the widget will always be at the end of all widgets when user change dir by clicking "Jump" or "Enter" buttons.
The reason was that the implementation remove the whole widget and create a new one and display it when change directory.
In this PR, we change the implementation so that the widget is divided to header, body and footer.
When changing dir, only the body got replaced. This way the widget will stay in the same place.
Also added "custom_layout" keyword argument so that the layout can be customized.