Set security protocol in Windows PowerShell install scripts #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses errors where utilities could not be installed in PowerShell 7.2.9 due to the security protocol not being set. SSL3 is obsolete and TLS 1.0 is deprecated. Both protocols are removed from the list of security protocols to try to set. The previous error message was misleading and has been updated for better future proofing. xref https://github.com/InsightSoftwareConsortium/itk-wasm/actions/runs/4053853776/jobs/6982667101
Addresses issue where `install_python.ps1` would sometimes fail to fetch `install_utils.ps1` script from GitHub due to error: > The SSL connection could not be established Mirrors routine used in `windows/install_utils.ps1` to set security protocol prior to attempting to fetch from upstream.
|
Note that this introduces an implicit requirement that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses errors where utilities could not be installed in PowerShell
7.2.9 due to the security protocol not being set.
It appears that SSL3 is obsolete and TLS 1.0 is deprecated. Both protocols are removed
from the list of security protocols to try to set.
The previous error message was misleading and has been updated for
better future proofing.
Resolves an issue in building ITK remote modules where SSL3 is not supported in PowerShell
7.2.9 in GitHub Actions
windows-2022runners, so PowerShell is not set to use TLS 1.2for fetching sources from python.org, therefore fetching sometimes fails.
xref https://github.com/InsightSoftwareConsortium/itk-wasm/actions/runs/4053853776/jobs/6982667101
With these changes ITK module builds successfully fetch Python sources using
install_python.ps1: https://github.com/tbirdso/ITKSplitComponents/actions/runs/4138506454/jobs/7154995112cc @thewtex @jcfr