Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support categorical counts in ak.unflatten #2099

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jan 10, 2023

Fully closes #2071 by generalising support for indexed types to any indexed layout type (not just non-categoricals).

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #2099 (6cd9cc3) into main (4db99b6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/numpy.py 68.96% <100.00%> (+0.43%) ⬆️
src/awkward/_util.py 82.07% <100.00%> (+0.25%) ⬆️
src/awkward/behaviors/string.py 76.66% <100.00%> (+0.63%) ⬆️
src/awkward/highlevel.py 76.21% <100.00%> (ø)
src/awkward/operations/ak_to_layout.py 88.37% <100.00%> (-0.76%) ⬇️
src/awkward/operations/ak_unflatten.py 95.45% <100.00%> (+0.14%) ⬆️
src/awkward/operations/ak_with_field.py 100.00% <100.00%> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview January 10, 2023 17:24 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! to_packed wouldn't project out categoricals—that would be undesirable in most applications of packing. But here we want to do it.

This fixes it; merge whenever you're ready.

@agoose77 agoose77 merged commit ad6aadb into main Jan 10, 2023
@agoose77 agoose77 deleted the agoose77/fix-unflatten-categorical branch January 10, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants