test: fix on win32 #2117
Merged
test: fix on win32 #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
commented
Jan 13, 2023
Comment on lines
+17
to
+28
| A = np.eye(2) * 2 | ||
| B = np.eye(3) * 3 | ||
| result = np.block( | ||
| [ | ||
| [ak.from_numpy(A), ak.from_numpy(np.zeros((2, 3)))], | ||
| [ak.from_numpy(np.ones((3, 2))), ak.from_numpy(B)], | ||
| ] | ||
| ) | ||
| assert isinstance(result, ak.Array) | ||
| assert ak._util.arrays_approx_equal(result, np.partition(data, [4, 6])) | ||
| assert ak._util.arrays_approx_equal( | ||
| result, np.block([[A, np.zeros((2, 3))], [np.ones((3, 2)), B]]) | ||
| ) |
There was a problem hiding this comment.
I just wanted a test that involves a list argument. np.block errors if one passes a tuple instead of a list, and it supports nested lists!
agoose77
commented
Jan 13, 2023
Comment on lines
+32
to
+36
| haystack = np.array([1, 2, 3, 4, 4, 5, 6, 7], dtype=np.int64) | ||
| needle = np.array([5, 0, 2], dtype=np.int64) | ||
| result = np.searchsorted(ak.from_numpy(haystack), ak.from_numpy(needle)) | ||
| assert isinstance(result, ak.Array) | ||
| assert ak._util.arrays_approx_equal(result, np.partition(data, np.array([4, 6]))) | ||
| assert ak._util.arrays_approx_equal(result, np.searchsorted(haystack, needle)) |
There was a problem hiding this comment.
np.searchsorted dodges the need to call np.partition with non-scalar arguments
Codecov Report
Additional details and impacted files
|
|
Merging as I'm confident we want to start the release, and this is a test failure through NumPy usage. |
|
Thanks. I'm sorry that I was out of touch for a bit. (Daughter's violin practice.) |
|
No problem! It's "out of work hours" right now, I just made a judgement call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, this test was failing on Windows 32-bit. I suspect it relates to the integer check of int64 against ULONGLONG, but I can't find any detailed information. It's easier just to try a different test.