Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: view for unknown scalar #2294

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix: view for unknown scalar #2294

merged 2 commits into from
Mar 9, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Mar 9, 2023 •
edited
Loading

This small PR fixes the assumption in TypeTracerArray.view that an array's shape always contains at least one element.

@agoose77 agoose77 requested a review from jpivarski March 9, 2023 14:12
@agoose77 agoose77 temporarily deployed to docs-preview March 9, 2023 14:18 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2294 (bdcc295) into main (d66c32a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_nplikes/typetracer.py 75.14% <100.00%> (+0.14%) ⬆️

jpivarski
jpivarski approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like something one would want to be able to do.

@agoose77 agoose77 marked this pull request as ready for review March 9, 2023 14:34
@agoose77 agoose77 merged commit 46aac98 into main Mar 9, 2023
@agoose77 agoose77 deleted the agoose77/fix-view-typetracer branch March 9, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski