Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add deployment notes to contributing guide #2300

Merged
merged 2 commits into from Mar 9, 2023
Merged

docs: add deployment notes to contributing guide #2300

merged 2 commits into from Mar 9, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Mar 9, 2023

These steps are things that are easy to forget, so they've been added to the contributing guide!

@agoose77 agoose77 requested a review from jpivarski March 9, 2023 21:48
@agoose77 agoose77 temporarily deployed to docs-preview March 9, 2023 21:54 — with GitHub Actions Inactive
jpivarski
jpivarski approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it (clicked on the link) in the deployment preview. Looks good!

jpivarski
jpivarski approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the wrong note on this one; it was intended for #2298.

But this is good, too. It's the checklist I mentioned on #2299 (and missed here because of getting confused about tabs).

@agoose77 agoose77 enabled auto-merge (squash) March 9, 2023 22:49
@agoose77 agoose77 disabled auto-merge March 9, 2023 22:50
@agoose77 agoose77 merged commit a0757d9 into main Mar 9, 2023
13 checks passed
@agoose77 agoose77 deleted the agoose77/docs-contributing-steps branch March 9, 2023 22:50
@agoose77 agoose77 temporarily deployed to docs-preview March 9, 2023 22:56 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agoose77 @jpivarski