refactor: improve broadcasting logic readability #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Apr 5, 2023
Comment on lines
+1010
to
1040
| def continuation(): | ||
| # Any EmptyArrays? | ||
| if any(x.is_unknown for x in contents): | ||
| return broadcast_any_unknown() | ||
|
|
||
| # Any NumpyArrays with ndim != 1? | ||
| elif any(x.is_numpy and x.purelist_depth != 1 for x in contents): | ||
| return broadcast_any_nd_numpy() | ||
|
|
||
| # Any IndexedArrays? | ||
| elif any((x.is_indexed and not x.is_option) for x in contents): | ||
| return broadcast_any_indexed() | ||
|
|
||
| # Any UnionArrays? | ||
| elif any(x.is_union for x in contents): | ||
| return broadcast_any_union() | ||
|
|
||
| # Any option-types? | ||
| elif any(x.is_option for x in contents): | ||
| return broadcast_any_option() | ||
|
|
||
| # Any list-types? | ||
| elif any(x.is_list for x in contents): | ||
| return broadcast_any_list() | ||
|
|
||
| # Any RecordArrays? | ||
| elif any(x.is_record for x in contents): | ||
| return broadcast_any_record() | ||
|
|
||
| else: | ||
| raise ak._errors.wrap_error( |
There was a problem hiding this comment.
In the end, this is the summary, the high-level overview of how broadcasting works. Splitting it out like this really helps to see this big picture! (And it's safer in that it limits variable scope.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the continuation in broadcasting into separate closures that we can more easily refactor.