fix: `ak.to_numpy` does not properly convert lists of empty string #2449

agoose77 · 2023-05-09T13:18:24Z

codecov · 2023-05-09T13:29:07Z

Codecov Report

Merging #2449 (b7971d3) into main (bbd4fc4) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted Files	Coverage Δ
src/awkward/contents/regulararray.py	`88.78% <66.66%> (-0.36%)`	⬇️
src/awkward/contents/listarray.py	`91.38% <100.00%> (+0.06%)`	⬆️
src/awkward/contents/listoffsetarray.py	`80.87% <100.00%> (+0.02%)`	⬆️

jpivarski

Good idea. That would be a surprise, only happening for empty arrays.

agoose77 added 2 commits May 9, 2023 14:14

test: add test

c902b70

fix: pass dtype in to_backend_array for strings

b7971d3

agoose77 requested a review from jpivarski May 9, 2023 13:18

agoose77 marked this pull request as ready for review May 9, 2023 13:19

agoose77 temporarily deployed to docs-preview May 9, 2023 13:32 — with GitHub Actions Inactive

jpivarski approved these changes May 10, 2023

View reviewed changes

agoose77 merged commit bc1b536 into main May 10, 2023
34 checks passed

agoose77 deleted the agoose77/fix-to-numpy-empty-string branch May 10, 2023 08:50