refactor: move responsibility for positional reducers to Reducer.apply
#2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
commented
Jun 7, 2023
Codecov Report
Additional details and impacted files
|
agoose77
force-pushed
the
agoose77/refactor-positional-reduction-in-reducer
branch
from
d13aa28
to
3faa298
Compare
jpivarski
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
This makes sense. I had felt that _reduce_next was a reasonable place to put reducer-stuff, and it's only in NumpyArray._reduce_next, but ak._reducers is also a reasonable place and this removes noise from numpyarray.py, which deals with many non-reducer things as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the responsibility for "fixing" positional reducers into
_reducers, such that reducers are self-contained. The same is not done forRecordArray, because this is effectively a separate reduction implementation that happens to use the same kernels.