Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deprecate the time __unit__ parameter #2518

Merged
merged 7 commits into from
Jun 10, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jun 9, 2023

In future we anticipate the introduction of a units system that uses this parameter. Moreover, datetimes should use the primitive to represent these types, as it's a fundamental type.

@agoose77 agoose77 temporarily deployed to docs-preview June 9, 2023 11:16 — with GitHub Actions Inactive
@agoose77 agoose77 requested a review from jpivarski June 9, 2023 12:12
@agoose77 agoose77 marked this pull request as ready for review June 9, 2023 12:14
@agoose77 agoose77 temporarily deployed to docs-preview June 9, 2023 12:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #2518 (0e0e584) into main (645c817) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/forms/numpyform.py 96.63% <100.00%> (+0.14%) ⬆️

@agoose77 agoose77 temporarily deployed to docs-preview June 9, 2023 13:02 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

All of the tests that assert the DeprecationWarnings will have to be changed later, but it will be obvious when the time comes.

src/awkward/forms/numpyform.py Outdated Show resolved Hide resolved
Co-authored-by: Jim Pivarski <jpivarski@users.noreply.github.com>
@agoose77 agoose77 enabled auto-merge (squash) June 10, 2023 00:06
@agoose77 agoose77 temporarily deployed to docs-preview June 10, 2023 00:16 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview June 10, 2023 16:48 — with GitHub Actions Inactive
@agoose77 agoose77 merged commit 1e65496 into main Jun 10, 2023
@agoose77 agoose77 deleted the agoose77/feat-deprecate-time-unit branch June 10, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants