Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pre-commit hooks #2532

Merged
merged 4 commits into from
Jun 30, 2023
Merged

chore: update pre-commit hooks #2532

merged 4 commits into from
Jun 30, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jun 20, 2023

@pre-commit-ci pre-commit-ci bot temporarily deployed to docs-preview June 20, 2023 02:19 Inactive
updates:
- [github.com/charliermarsh/ruff-pre-commit: v0.0.272 → v0.0.275](astral-sh/ruff-pre-commit@v0.0.272...v0.0.275)
- [github.com/codespell-project/codespell: v2.2.4 → v2.2.5](codespell-project/codespell@v2.2.4...v2.2.5)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 78fc6e1 to a83b85f Compare June 27, 2023 01:36
@pre-commit-ci pre-commit-ci bot temporarily deployed to docs-preview June 27, 2023 01:48 Inactive
@henryiii
Copy link
Member

pre-commit.ci autofix

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2532 (e494db0) into main (bb327c7) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_behavior.py 92.47% <ø> (ø)
src/awkward/_do.py 83.64% <ø> (ø)
src/awkward/_nplikes/__init__.py 80.95% <ø> (ø)
src/awkward/_errors.py 79.11% <100.00%> (ø)

@pre-commit-ci pre-commit-ci bot temporarily deployed to docs-preview June 29, 2023 15:19 Inactive
@henryiii
Copy link
Member

I wonder if we should swap the order of black and Ruff?

@jpivarski
Copy link
Member

It was my understanding that black runs before Ruff, which sounds to me like the right order.

  • If black fixes any formatting issues that Ruff would complain about, then black should go before Ruff.
  • Since black changes the line numbers of issues that Ruff would complain about, and changes the lines on which a # noqa comment is active, black should go before Ruff.
  • If Ruff changes the code to fix easy issues (I think it does), and if Ruff's output format is not acceptable to black, then Ruff should go before black.

Only the last consideration implies Ruff → black, and if all three considerations apply, then we'd have to do black → Ruff → black. (In principle, it might never terminate, since the second run of black could move the positions of # noqa comments! But I would think that enough Ruff users are also black users, and black is not very configurable or at least has well-established defaults, that these issues would get resolved by the Ruff community, not by doing something special downstream.)

@jpivarski jpivarski enabled auto-merge (squash) June 30, 2023 14:33
@jpivarski jpivarski temporarily deployed to docs-preview June 30, 2023 14:47 — with GitHub Actions Inactive
@jpivarski jpivarski merged commit 228577b into main Jun 30, 2023
@jpivarski jpivarski deleted the pre-commit-ci-update-config branch June 30, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants