fix: check validity error properly

[agoose77]

The parameters check for validity error does not recurse in the existing implementation

[codecov]

Codecov Report

Merging #2550 (4cba0f5) into main (1f6041e) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted Files	Coverage Δ
src/awkward/_do.py	83.64% <ø> (+0.31%)	⬆️
src/awkward/contents/content.py	76.00% <ø> (-0.04%)	⬇️
src/awkward/contents/indexedoptionarray.py	88.32% <33.33%> (-0.28%)	⬇️
src/awkward/contents/indexedarray.py	78.99% <100.00%> (+0.14%)	⬆️

[jpivarski]

I don't think it was failing to recurse before: my reading of the red/removed code is that it would only stop recursion if it hit an error, which is what it's supposed to do. (I didn't construct a test, though.)

Anyway, the new code also looks correct but it's better from an OOP point of view.

This is a simple PR and it looks like you're done; I'll merge it immediately.

[agoose77]

I don't think it was failing to recurse before: my reading of the red/removed code is that it would only stop recursion if it hit an error, which is what it's supposed to do. (I didn't construct a test, though.)

The intention was that we have cross-layout checks in a separate method. However, only ak._do.validity_error checked this for the top-level layout (hence the test). We might still want a dedicated ak.Content._validity_error_parameters function in future (if we have such checks), but this is L3 and we don't currently need it.