Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert unknown-length to index in ListOffsetArray.to_RegularArray #2560

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix: convert unknown-length to index in ListOffsetArray.to_RegularArray #2560

merged 2 commits into from
Jul 3, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jul 2, 2023 •
edited
Loading

This fixes a bug that is raised during the strict dask-awkward test suite.

@agoose77 agoose77 requested a review from jpivarski July 2, 2023 22:22
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #2560 (84b33eb) into main (002a3af) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/listoffsetarray.py 80.90% <100.00%> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview July 2, 2023 22:25 — with GitHub Actions Inactive
jpivarski
jpivarski approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and it looks very straightforward.

@jpivarski jpivarski merged commit 953fc59 into main Jul 3, 2023
@jpivarski jpivarski deleted the agoose77/fix-to-regular-array-size branch July 3, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski