fix: remove unneeded cast #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
force-pushed
the
agoose77/fix-slice-listoffsetarray
branch
from
f863d64
to
7bf8964
Compare
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Aug 16, 2023
Comment on lines
420
to
421
| if head is NO_HEAD: | ||
| return self |
There was a problem hiding this comment.
Suggested change
| if head is NO_HEAD: | |
| return self | |
| if ak._util.win: | |
| advanced = advanced.to_nplike(self._backend.nplike) | |
| if head is NO_HEAD: | |
| return self |
It seems that only Windows needs this cast. (Maybe, depending on what the other Windows tests would have done if they had been allowed to run, and maybe the test would fail on Windows even without this line and we're looking at something else.)
https://github.com/scikit-hep/awkward/actions/runs/5884127678/job/15958232220?pr=2653
There was a problem hiding this comment.
I think I've fixed it - oversight on my part :)
There was a problem hiding this comment.
In that case, I'll enable auto-merge. Disable it if you see something else.
agoose77
force-pushed
the
agoose77/fix-slice-listoffsetarray
branch
from
30bb165
to
41c037d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug during slicing for a record of ragged lists. This PR fixes the bug, which was introduced during the backend addition.