-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: guard broadcast_and_apply
from mixed backends
#2678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
agoose77
commented
Aug 29, 2023
agoose77
commented
Aug 29, 2023
agoose77
commented
Aug 29, 2023
agoose77
commented
Aug 29, 2023
jpivarski
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
broadcast_and_apply
throws an error if the given arrays do not share the same backend.At a high level, all
ak.XXX
operations that accept multiple array arguments should effectively computeWe could add a helper to do this, although given that each
ak.XXX
function needs to set different layout conversion flags, this is probably best avoided.There's an argument to be made for making
broadcast_and_apply
be more permissive and perform the coercion itself. However, I think we want to coerce to the same backend in the highlevelak.XXX
functions ASAP, i.e. before broadcasting.Whilst I was here, I cleaned up some of the routines that use
backend_of
.