Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for Jitify performing a one-time only warm-up #3113

Merged
merged 10 commits into from
May 28, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented May 13, 2024

fixes #3111

@ianna ianna changed the title fix: wait for Jitify that is performing a one-time only warm-up fix: wait for Jitify performing a one-time only warm-up May 13, 2024
@ianna ianna requested a review from jpivarski May 13, 2024 15:34
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski and @ManasviGoyal - a number of tests were failing due to Jitify performing a one-time only warm-up. This seems to fix all of them.

tests/test_2327_array_interface.py Outdated Show resolved Hide resolved
@jpivarski
Copy link
Member

Is it a new version of CuPy? (I'm assuming that Jitify is a part of CuPy, rather than a dependency, but if it's the latter: is it a new version of Jitify?)

@ianna
Copy link
Collaborator Author

ianna commented May 13, 2024

Is it a new version of CuPy? (I'm assuming that Jitify is a part of CuPy, rather than a dependency, but if it's the latter: is it a new version of Jitify?)

I have cupy 13.1.0 installed: both conda and pip installations give the same error. Looking at the code the error looks superficial.

@jpivarski jpivarski enabled auto-merge (squash) May 28, 2024 13:43
@jpivarski jpivarski merged commit 6cff8e9 into main May 28, 2024
41 checks passed
@jpivarski jpivarski deleted the ianna/jitify_is_performing_a_one-time_only_warm-up_1 branch May 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_wrap_index_cupy, test_from_dlpack_cupy and 361 cuda tests fail with 'PerformanceWarning'
2 participants