Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SliceVarNewAxis #694

Merged
merged 6 commits into from
Feb 2, 2021
Merged

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski merged commit d61011a into jpivarski/fixes-for-scipy-prep Feb 2, 2021
@jpivarski jpivarski deleted the jpivarski/SliceVarNewAxis branch February 2, 2021 08:48
jpivarski added a commit that referenced this pull request Feb 2, 2021
* Fixes for SciPy 2021 prep.

* Fixed an masking-partitioned bug and added ak.materialize to diagnose (it wasn't related to virtualness).

* SliceVarNewAxis (#694)

* Working on SliceVarNewAxis.

* First carry implemented on Slices.

* All SliceItems have 'carry' operations, need to move to kernels.

* Cleaned up but still need to add kernels.

* Added SliceVarNewAxis_to_SliceJagged64 kernel.

* All SliceItem::carry are in kernels.

* Fix min/max for partitioned data.
jpivarski added a commit that referenced this pull request Jul 21, 2021
* Removed the feature and fixed tests without removing dead code.

* Removed the now-dead code (including a 'FIXME: move to kernel').
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant