Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test dependency from nteract-scrapbook to scrapbook #1725

Closed
1 task done
matthewfeickert opened this issue Dec 7, 2021 · 3 comments
Closed
1 task done

Update test dependency from nteract-scrapbook to scrapbook #1725

matthewfeickert opened this issue Dec 7, 2021 · 3 comments
Labels
chore Other changes that don't modify src or test files docs Documentation related good first issue Good for newcomers

Comments

@matthewfeickert
Copy link
Member

Summary

Running the notebook tests generates the warning

warnings.warn("'nteract-scrapbook' package has been renamed to `scrapbook`. No new releases are going out for this old package name.", FutureWarning)

as nteract-scrapbook is now scrapbook. All that needs to be done is to change the name used in steup.py for the test extra:

pyhf/setup.py

Line 42 in 29bc6da

'nteract-scrapbook~=0.2',

Additional Information

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@matthewfeickert matthewfeickert added good first issue Good for newcomers docs Documentation related chore Other changes that don't modify src or test files labels Dec 7, 2021
@manulpatel
Copy link

@matthewfeickert Hello! I want to get started to contribute to pyhf. Could you please assign this to me? So that I can quickly fix and close this issue.

@matthewfeickert matthewfeickert mentioned this issue Apr 16, 2023
Merged
4 tasks
@matthewfeickert
Copy link
Member Author

Resolved by PR #1841.

@matthewfeickert
Copy link
Member Author

Thanks @manulpatel, but it seems that this was an old issue that was already taken care of some time ago. If you want to get involved with development please check out the CONTRIBUTING.md. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Other changes that don't modify src or test files docs Documentation related good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewfeickert @manulpatel