-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Override error on filterwarnings to pass notebook tests #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> DeprecationWarning: Passing unrecognized arguments to super(PapermillNotebookClient)...
matthewfeickert
commented
Apr 6, 2022
matthewfeickert
commented
Apr 6, 2022
1 task
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 68 68
Lines 4315 4315
Branches 725 725
=======================================
Hits 4236 4236
Misses 46 46
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
matthewfeickert
commented
Apr 6, 2022
matthewfeickert
changed the title
fix: Get notebook tests working with modern papermill
fix: Ignore filterwarnings to pass notebook tests and update papermill
Apr 6, 2022
matthewfeickert
changed the title
fix: Ignore filterwarnings to pass notebook tests and update papermill
fix: Override error on filterwarnings to pass notebook tests
Apr 6, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To get the notebook tests to pass given the many warnings that pop up from the Jupyter infrastructure and
papermill
, override the ini option forfilterwarnings
(added in PR #1773) with an empty list to disable error on filterwarnings as the notebook tests are testing for notebooks to run with the latest API, not if Jupyter infrastructure is warning free.The use of
PYTHONWARNINGS='default'
should be possible, but is causing errors and is now Issue #1840.Use
scrapbook
as it is the new name ofnteract-scrapbook
andnteract-scrapbook
is no longer maintained or developed.Restrict
papermill
andscrapbook
to compatible releases at the patch level for API stability.Use the
papermill.execute_notebook
cwd
optional argument to change the execution directory safely to avoid having the state of operations change in the test.Add concurrency group to avoid wasting run time.
Resolves #1725
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: