Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add yesqa pre-commit hook #1932

Merged
merged 3 commits into from
Aug 10, 2022
Merged

ci: Add yesqa pre-commit hook #1932

merged 3 commits into from
Aug 10, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 10, 2022

Description

Add yesqa pre-commit hook and use it to remove an unused noqa: F401 from

from pyhf.infer import intervals # noqa: F401

As the use of the flake8 config options count and statistics in setup.cfg cause issues with yesqa (c.f. asottile/yesqa#132, PyCQA/flake8#1458) move them to the flake8 pre-commit hook as args. (Thanks @henryiii for the good suggestion.)

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add and apply yesqa pre-commit hook.
* Move flake8 options 'count' and 'statistics' from the flake8 config
in setup.cfg to args for the flake8 pre-commit hook to avoid problems
with yesqa.
   - c.f. https://github.com/asottile/yesqa/issues/132

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1932 (42d2f1b) into master (1494b66) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1932   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4330     4330           
  Branches      729      729           
=======================================
  Hits         4251     4251           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.37% <100.00%> (ø)
doctest 60.66% <100.00%> (ø)
unittests-3.10 96.05% <100.00%> (ø)
unittests-3.7 96.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/infer/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kratsg kratsg merged commit b58a6b7 into master Aug 10, 2022
@kratsg kratsg deleted the ci/add-yesqa-pre-commit-hook branch August 10, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants