Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify absolute/relative for histosys #1971

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Aug 30, 2022

Pull Request Description

Resolves #1718.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Clarify the schema data for histosys is absolute and not relative counts in the
  Correlated Shape (histosys) documentation example for likelihood specification.

@kratsg kratsg added the docs Documentation related label Aug 30, 2022
@kratsg kratsg self-assigned this Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 98.24% // Head: 98.24% // No change to project coverage 👍

Coverage data is based on head (8c7f0c6) compared to base (e366eb9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1971   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          68       68           
  Lines        4378     4378           
  Branches      726      726           
=======================================
  Hits         4301     4301           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 26.58% <ø> (ø)
doctest 60.57% <ø> (ø)
unittests-3.10 96.13% <ø> (ø)
unittests-3.7 96.12% <ø> (ø)
unittests-3.8 96.16% <ø> (ø)
unittests-3.9 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kratsg thanks for this and I think the clarification is good. I have a minor suggestion though.

docs/likelihood.rst Outdated Show resolved Hide resolved
@matthewfeickert
Copy link
Member

Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
@matthewfeickert matthewfeickert merged commit 8db4a1f into master Sep 3, 2022
@matthewfeickert matthewfeickert deleted the docs/absoluteRelativeUncertainty branch September 3, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify absolute vs relative for likelihood specification
2 participants