Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add guards against shared shapesys paramsets #1977

Merged
merged 11 commits into from
Sep 7, 2022
Merged

fix: Add guards against shared shapesys paramsets #1977

merged 11 commits into from
Sep 7, 2022

Commits on Sep 5, 2022

  1. move is_shared to class member of builder

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2afe7f9 View commit details
    Browse the repository at this point in the history

  2. catch is_shared in pdf.py

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8a71af8 View commit details
    Browse the repository at this point in the history

  3. typo

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    cc31acd View commit details
    Browse the repository at this point in the history

  4. actually work

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3835f41 View commit details
    Browse the repository at this point in the history

  5. add test to catch problematic

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2f49fa1 View commit details
    Browse the repository at this point in the history

  6. add test

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    5ca6c1d View commit details
    Browse the repository at this point in the history

  7. fix up more

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    16ac2af View commit details
    Browse the repository at this point in the history

  8. make sure we have tests covering the cases we expect

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a0b47ea View commit details
    Browse the repository at this point in the history

  9. fix custom mods

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    63e976a View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge branch 'master' into fix/isSharedRegression_Shapesys

    @kratsg
    kratsg authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4c2ccf1 View commit details
    Browse the repository at this point in the history

  2. use dict comprehension

    @matthewfeickert
    matthewfeickert committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    39fe675 View commit details
    Browse the repository at this point in the history