Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backport): Raise error when converting xml workspaces without data #2166

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

matthewfeickert
Copy link
Member

Description

Backport PR #2109

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2109

@matthewfeickert matthewfeickert added fix A bug fix backport Backport PRs from main to release branch labels Apr 6, 2023
@matthewfeickert matthewfeickert self-assigned this Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.7.x@465c2ba). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2166   +/-   ##
=================================================
  Coverage                  ?   98.30%           
=================================================
  Files                     ?       69           
  Lines                     ?     4532           
  Branches                  ?      801           
=================================================
  Hits                      ?     4455           
  Misses                    ?       45           
  Partials                  ?       32           
Flag Coverage Δ
contrib 27.51% <0.00%> (?)
doctest 61.12% <0.00%> (?)
unittests-3.10 96.31% <0.00%> (?)
unittests-3.11 96.31% <0.00%> (?)
unittests-3.7 96.29% <0.00%> (?)
unittests-3.8 96.33% <0.00%> (?)
unittests-3.9 96.35% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit 53361dd into release/v0.7.x Apr 6, 2023
@matthewfeickert matthewfeickert deleted the backport/fix-raise-error branch April 6, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants