Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add build-system to pyproject.toml #639

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Nov 15, 2019

Description

Fixes #638

This PR needs to add [build-system] in pyproject.toml which was missing in order to run the pypa-publishing recipe introduced in #638. Additionally, we didn't catch this because the test workflow wasn't being run to check if we could build... now we check and we're good to go.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Fixes PR #638
* Add build-system in pyproject.toml which was missing in order to run the PyPA-publishing recipe introduced in #638
* Make sure workflow for publish builds packages, but does not publish to TestPyPI

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          42       42           
  Lines        2547     2547           
  Branches      345      345           
=======================================
  Hits         2418     2418           
  Misses         85       85           
  Partials       44       44
Flag Coverage Δ
#unittests 94.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a02de...fa7f8c2. Read the comment docs.

@matthewfeickert matthewfeickert changed the title fix: add build-system fix: Add build-system Nov 15, 2019
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this, @kratsg!

@matthewfeickert matthewfeickert changed the title fix: Add build-system fix: Add build-system to pyproject.toml Nov 15, 2019
@matthewfeickert matthewfeickert added build Changes that affect the build system or external dependencies CI CI systems, GitHub Actions labels Nov 15, 2019
@matthewfeickert matthewfeickert merged commit 6f50690 into master Nov 15, 2019
@matthewfeickert matthewfeickert deleted the fix/buildSystem branch November 15, 2019 03:07
@matthewfeickert matthewfeickert added the fix A bug fix label Nov 15, 2019
matthewfeickert pushed a commit that referenced this pull request Nov 15, 2019
…ep (#640)

* More fixes to workflow in #639, only push to testpypi on pushes on master
* Only use scm if the current commit is not tagged
* Protect forks from publishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies CI CI systems, GitHub Actions fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants