Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: rwgt overwritten by weights #230

Closed
APN-Pucky opened this issue Feb 20, 2024 · 0 comments · Fixed by #231
Closed

Bug: rwgt overwritten by weights #230

APN-Pucky opened this issue Feb 20, 2024 · 0 comments · Fixed by #231

Comments

@APN-Pucky
Copy link
Member

https://github.com/scikit-hep/scikit-hep-testdata/blob/main/src/skhep_testdata/data/pylhe-testlhef3.lhe#L337

  <rwgt>
   <wgt id="1001"> 0.50109E+02 </wgt>
   <wgt id="1002"> 0.45746E+02 </wgt>
   <wgt id="1003"> 0.52581E+02 </wgt>
   <wgt id="1004"> 0.50109E+02 </wgt>
   <wgt id="1005"> 0.45746E+02 </wgt>
   <wgt id="1006"> 0.52581E+02 </wgt>
   <wgt id="1007"> 0.50109E+02 </wgt>
   <wgt id="1008"> 0.45746E+02 </wgt>
   <wgt id="1009"> 0.52581E+02 </wgt>
  </rwgt>
  <weights> 1.000e+00 0.204e+00 1.564e+00 </weights>

Unfortunately, #220 overwrites the values from rwgt by those of weights. I did not know madgraph uses both...

Ideally I think one would have both available as rwgt and weight attribute, but that would be a breaking change i.e. renaming current weights to rwgt. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant