Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: https://root-forum.cern.ch/t/wrong-branch-type-detection/59236/25 #1207

Merged
merged 1 commit into from
May 7, 2024

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski merged commit 7ab71bd into main May 7, 2024
24 checks passed
@jpivarski jpivarski deleted the jpivarski/fix-TBranch-title branch May 7, 2024 20:44
@umute97
Copy link

umute97 commented May 8, 2024

Is there a way to make this available for python3.7? Unfortunately, I have to develop for this rather antique version...

@jpivarski
Copy link
Member Author

Uproot doesn't declare itself to be usable in Python 3.7, but it probably is. (At one point, I made it work in Python 2.6! That's no longer true, though.)

I just tried to hack it by checking out the repo from GitHub, changing the line

requires-python = ">=3.8"

to say 3.7, and then pip install -e . (local installation). It didn't work because there's no compatible Awkward Array version for Python 3.8, and that would require a custom installation, so it's turning into a rabbit hole.

I think you don't need the above for your analysis, right? It's just changing the title of the TBranches that Uproot writes. ROOT still recognizes the data with slightly different TBranch titles. (I experimented on that yesterday.)

@umute97
Copy link

umute97 commented May 8, 2024

It didn't work because there's no compatible Awkward Array version for Python 3.8, and that would require a custom installation, so it's turning into a rabbit hole.

Bummer ¯_(ツ)_/¯

I think you don't need the above for your analysis, right? It's just changing the title of the TBranches that Uproot writes. ROOT still recognizes the data with slightly different TBranch titles. (I experimented on that yesterday.)

Yes, don't worry! While experimenting I just realized that I'm still running an old version of uproot and was wondering why and update it if I can. Now I know. Thanks for your continued effort for providing this awesome interface!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants