-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get coordinate classes to work for numpy #466
Conversation
7eacc64
to
4d41f5c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 86.68% 86.85% +0.16%
==========================================
Files 96 96
Lines 11836 11919 +83
==========================================
+ Hits 10260 10352 +92
+ Misses 1576 1567 -9 ☔ View full report in Codecov by Sentry. |
4b3c48b
to
18a6c94
Compare
18a6c94
to
991f178
Compare
80285ea
to
f15c8ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason this wasn't working before is because, in the original implementation, I didn't intend NumPy Vector arrays to be used like this. But it's not unreasonable to expect this behavior, so I'm glad you got it working!
Thanks for the review! |
Description
Fixes #194
Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.
Checklist
$ pre-commit run --all-files
or$ nox -s lint
)$ pytest
or$ nox -s tests
)$ cd docs; make clean; make html
or$ nox -s docs
)$ pytest --doctest-plus src/vector/
or$ nox -s doctests
)Before Merging