Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility between pillow 10.1.0 and imageio<=2.31.5 breaks roundtrip test #7207

Closed
lagru opened this issue Oct 16, 2023 · 0 comments · Fixed by #7245
Closed

Incompatibility between pillow 10.1.0 and imageio<=2.31.5 breaks roundtrip test #7207

lagru opened this issue Oct 16, 2023 · 0 comments · Fixed by #7245
Labels
⬆️ Upstream Needs help from or involves an upstream project 🐛 Bug

Comments

@lagru
Copy link
Member

lagru commented Oct 16, 2023 •
edited
Loading

Description:

See imageio/imageio#1044 for the upstream issue or this job for our test failure. I'll add a temporary pin to pillow next to fix our CI in the meantime.

Let's keep this issue open until a patched imageio allows us to revert that pin so we don't forget.

Way to reproduce:

Ensure pillow 10.1.0 and imageio<=2.31.5 are installed and run

$ spin test -- -k imsave_roundtrip
[...]
                # Let pillow know that it is okay to return 16-bit
>               image.mode = desired_mode
E               AttributeError: property 'mode' of 'PngImageFile' object has no setter
@lagru lagru added ⬆️ Upstream Needs help from or involves an upstream project 🐛 Bug labels Oct 16, 2023
@lagru lagru mentioned this issue Oct 16, 2023
Merged
sitic added a commit to cardiacvision/optimap that referenced this issue Oct 19, 2023
@sitic
Pin pillow<10.1.0 until imageio is fixed
2b43faa 
Pillow 10.1.0 introduces incompatabilities with scikit-image.

Revert when
scikit-image/scikit-image#7207
imageio/imageio#1044
is fixed.
sitic added a commit to sitic/scikit-image that referenced this issue Nov 20, 2023
@sitic
Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0
0124a61 
Require the new imageio release 2.33.0 which fixes the incompatibility with Pillow>=10.1.0.

fixes scikit-image#7207
reverts scikit-image#7208
@sitic sitic mentioned this issue Nov 20, 2023
Merged
jarrodmillman added a commit that referenced this issue Nov 24, 2023
@sitic @mkcor @jarrodmillman
Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0 (#7245)
4212f02 
* Revert "Pin Pillow until incompatibility with imageio is fixed. (#7208)"

This reverts commit e6cb9a9.

* Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0

Require the new imageio release 2.33.0 which fixes the incompatibility with Pillow>=10.1.0.

fixes #7207
reverts #7208

* Apply suggestions from code review

---------

Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
@cbouss cbouss mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⬆️ Upstream Needs help from or involves an upstream project 🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0 sitic/scikit-image
1 participant
@lagru