Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Pillow to <10.1.0 until incompatibility with imageio is fixed #7208

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

lagru
Copy link
Member

@lagru lagru commented Oct 16, 2023

An update to Pillow (10.1.0) breaks for most recent imageio (<=2.31.5). See imageio/imageio#1044 [1] for the upstream issue. Tracked in #7207.

Description

Checklist

Release note

Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically:

...

An update to Pillow (10.1.0) breaks for most recent imageio (<=2.31.5).
See imageio/imageio#1044 [1] for the upstream issue.

[1] imageio/imageio#1044
@lagru lagru added the 🔧 type: Maintenance Refactoring and maintenance of internals label Oct 16, 2023
@mkcor
Copy link
Member

mkcor commented Oct 16, 2023

I'll merge since I don't believe the failure in doc/examples/registration/plot_stitching.py might have anything to do with pinning the Pillow dependency.

@mkcor mkcor merged commit e6cb9a9 into scikit-image:main Oct 16, 2023
23 of 24 checks passed
@stefanv stefanv added this to the 0.22 milestone Oct 16, 2023
@lagru lagru deleted the tmp-pin-pillow branch October 16, 2023 22:23
@jarrodmillman jarrodmillman modified the milestones: 0.22, 0.23 Oct 24, 2023
sitic added a commit to sitic/scikit-image that referenced this pull request Nov 20, 2023
sitic added a commit to sitic/scikit-image that referenced this pull request Nov 20, 2023
Require the new imageio release 2.33.0 which fixes the incompatibility with Pillow>=10.1.0.

fixes scikit-image#7207
reverts scikit-image#7208
jarrodmillman added a commit that referenced this pull request Nov 24, 2023
* Revert "Pin Pillow until incompatibility with imageio is fixed. (#7208)"

This reverts commit e6cb9a9.

* Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0

Require the new imageio release 2.33.0 which fixes the incompatibility with Pillow>=10.1.0.

fixes #7207
reverts #7208

* Apply suggestions from code review

---------

Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
@lagru lagru mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants