Include example use of function regionprops_table in the docs #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupault
reviewed
Jan 4, 2020
| @@ -47,3 +58,12 @@ | |||
|
|
|||
| ax.axis((0, 600, 600, 0)) | |||
| plt.show() | |||
|
|
|||
| props = regionprops_table(label_img, properties=('centroid', | |||
There was a problem hiding this comment.
We could perhaps say here that regionprops_table actually computes the properties, while regionprops only does lazy execution.
soupault
added
the
📄 type: Documentation
Co-authored-by: Egor Panfilov <egor.v.panfilov@gmail.com>
Co-authored-by: Egor Panfilov <egor.v.panfilov@gmail.com>
soupault
reviewed
Jan 10, 2020
| @@ -22,9 +24,17 @@ | |||
|
|
|||
| image = rotate(image, angle=15, order=0) | |||
|
|
|||
| rr, cc = ellipse(100, 100, 60, 50) | |||
| image[rr, cc] = 1 | |||
There was a problem hiding this comment.
I have just realized that there is an issue with coordinates in plotting - https://scikit-image.org/docs/dev/auto_examples/segmentation/plot_regionprops.html. See how the axes are transposed with respect to the ellipse.
There was a problem hiding this comment.
Good catch! Fixing the major vs minor axes now.
There was a problem hiding this comment.
Done in cdf1678. Thanks again :)
jni
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4335.
First, I thought about adding another region. It's only a toy example, but it feels too odd to write a for loop to iterate on a length-1 list.
Then, I appended a call to
regionprops_tableand displayed the result.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x