Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multichannel to channel_axis (2 of 6): transform functions #5285

Merged
merged 16 commits into from Apr 26, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Mar 23, 2021

follows #5284. implements channel_axis in the transform module

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 📜 type: API Involves API change(s) label Mar 23, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 23, 2021

Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-01 11:56:17 UTC

Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grlee77 I've made only a very minor comment, which I should have caught in the last PR — shouldn't some tests be updated to use the new form rather than wrapped in an expected_warnings context?

skimage/feature/tests/test_basic_features.py Outdated Show resolved Hide resolved
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
@grlee77
Copy link
Contributor Author

grlee77 commented Apr 9, 2021

This one has one review and should be good to go if anyone else could do a quick check

@grlee77 grlee77 added this to the 0.19 milestone Apr 21, 2021
@alexdesiqueira alexdesiqueira merged commit 3b332b7 into scikit-image:main Apr 26, 2021
@alexdesiqueira
Copy link
Member

This one is huge! Thank you Greg!

@grlee77 grlee77 moved this from In progress to Done in skimage2 API Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 type: API Involves API change(s)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants