Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multichannel to channel_axis (3 of 6): filters #5286

Merged
merged 19 commits into from May 11, 2021
Merged

multichannel to channel_axis (3 of 6): filters #5286

merged 19 commits into from May 11, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Mar 23, 2021

follows #5285. Implements channel_axis for the filters module

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 📜 type: API Involves API change(s) label Mar 23, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 23, 2021 •
edited

Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-01 12:00:55 UTC

@grlee77 grlee77 mentioned this pull request Mar 23, 2021
Merged
@grlee77 grlee77 added this to In progress in skimage2 API Mar 23, 2021
@alexdesiqueira alexdesiqueira mentioned this pull request Mar 31, 2021
Closed
@grlee77 @stefanv
Apply suggestions from code review
9bd5691 
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
@grlee77 grlee77 added this to the 0.19 milestone Apr 21, 2021
alexdesiqueira
alexdesiqueira approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@alexdesiqueira alexdesiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Greg!

jni
jni reviewed May 11, 2021
View reviewed changes
skimage/feature/_hog.py
if multichannel is None:
multichannel = (image.ndim == 3)

multichannel = channel_axis is not None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need some moveaxis logic here @grlee77 @alexdesiqueira?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, just saw that @channel_as_last_axis takes care of that for us. Got confused because other functions don't do that. 🙏

@jni jni merged commit c1038eb into scikit-image:main May 11, 2021
@mkcor mkcor mentioned this pull request Jun 10, 2021
Merged
@grlee77 grlee77 moved this from In progress to Done in skimage2 API Jun 21, 2021
@grlee77 grlee77 deleted the channel_axis_filters branch July 8, 2021 20:45
@grlee77 grlee77 mentioned this pull request Sep 7, 2021
Closed
@grlee77 grlee77 mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@alexdesiqueira alexdesiqueira alexdesiqueira approved these changes

Assignees
No one assigned
Labels
📜 type: API Involves API change(s)
Projects
skimage2 API
Done
Milestone
0.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grlee77 @pep8speaks @jni @alexdesiqueira