multichannel to channel_axis (5 of 6): restoration #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Otherwise, LGTM 🙂 |
alexdesiqueira
approved these changes
May 11, 2021
|
Nope, I broke everything 😢 Sorry! Could you undo 4c06e3c and fix the conflicts? |
slice_at_axis is a vendored copy of numpy.lib.arraypad._slice_at_axis
If needed can revisit adding custom channel_axis support to the underlying RegionProps class
grlee77
force-pushed
the
channel_axis_restoration
branch
from
4c06e3c
to
8ff64a4
Compare
No worries, the inpainting file was modified in two other recently merged PRs as well, so that became a bit more tricky. It should be ready now if CI passes |
|
Thank you Greg! @jni wanna check and merge? 🙂 |
jni
approved these changes
May 12, 2021
| for c in range(image.shape[-1]): | ||
| out[..., c] = _denoise_tv_chambolle_nd(image[..., c], weight, eps, | ||
| for c in range(image.shape[channel_axis]): | ||
| out[_at(c)] = _denoise_tv_chambolle_nd(image[_at(c)], weight, eps, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #5287. Implements
channel_axisfor the restoration moduleDescription
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.