Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multichannel to channel_axis (4 of 6): metrics and measure #5287

Merged
merged 4 commits into from May 12, 2021
Merged

multichannel to channel_axis (4 of 6): metrics and measure #5287

merged 4 commits into from May 12, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Mar 23, 2021

follows #5286. Implements channel_axis for the metrics module

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 📜 type: API Involves API change(s) label Mar 23, 2021
@grlee77 grlee77 mentioned this pull request Mar 23, 2021
Merged
@grlee77 grlee77 added this to In progress in skimage2 API Mar 23, 2021
@alexdesiqueira alexdesiqueira mentioned this pull request Mar 31, 2021
Closed
@grlee77 grlee77 added this to the 0.19 milestone Apr 21, 2021
@alexdesiqueira
Copy link
Member

Looks good, thank you @grlee77! @jni, the Guardian of the Dimensions, would you like to check — and merge if ready for you? 🙂

@jni
Copy link
Member

jni commented May 11, 2021

I mean... There's a lot of red in the CI... 😂

@alexdesiqueira
Copy link
Member

It was okay before 😆 I broke something, for sure!

@jni
Copy link
Member

jni commented May 11, 2021

@grlee77 can you rebase? Let's get these in!

@grlee77
add slice_at_axis utility
649cb64 
slice_at_axis is a vendored copy of numpy.lib.arraypad._slice_at_axis
@grlee77
add channel_axis support to metrics.structural_similarity
f2921cc
@grlee77
DOC: add channel axis note to regionprops docstrings
72587fe 
If needed can revisit adding custom channel_axis support to the underlying RegionProps class
@grlee77
consistent use of backticks for variable names in warning messages
d1c5324
@grlee77 grlee77 force-pushed the channel_axis_metrics_and_measure branch from 84efb7b to d1c5324 Compare May 11, 2021 12:43
@grlee77
Copy link
Contributor Author

grlee77 commented May 11, 2021

@grlee77 can you rebase? Let's get these in!

This should be ready now (pending CI success)

@grlee77 grlee77 mentioned this pull request May 11, 2021
Merged
@jni jni merged commit 3cb4d32 into scikit-image:main May 12, 2021
@grlee77 grlee77 moved this from In progress to Done in skimage2 API Jun 21, 2021
@grlee77 grlee77 deleted the channel_axis_metrics_and_measure branch July 8, 2021 20:44
@grlee77 grlee77 mentioned this pull request Sep 7, 2021
Closed
@grlee77 grlee77 mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@alexdesiqueira alexdesiqueira alexdesiqueira approved these changes

Assignees
No one assigned
Labels
📜 type: API Involves API change(s)
Projects
skimage2 API
Done
Milestone
0.19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grlee77 @alexdesiqueira @jni