Update OpenBLAS to v0.3.17 #6607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanv
approved these changes
Nov 2, 2022
|
@scikit-image/core I think the old OpenBLAS had a threading issue, affecting parallel computations. We need this to get the wheel builds working, so I'm merging for expediency; please let me know if you have concerns. |
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Nov 3, 2022
I missed a few places where NumPy requirements are set.
Merged
lagru
added
🔧 type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting regular CI failures particularly related to multiprocessing. Stefan suspected it might be fixed by an updated OpenBLAS. I've rerun the CI on this PR mulitple times and it passed everytime, so I think this may solve the annoying CI failures.
This involves dropping NumPy 1.20 (numpy/numpy#19495). According to NEP 29, we should drop 1.20 by January 2023. Given the current status of main, I suspect we will be lucky to get a scikit 0.20 final release out this month. So we will only be a month of so early on dropping NumPy 1.20 according to NEP 29. Moreover, we already require more recent versions of NumPy for some of our wheels.