Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #6607 #6610

Merged
merged 1 commit into from Nov 3, 2022
Merged

Fixes for #6607 #6610

merged 1 commit into from Nov 3, 2022

Conversation

jarrodmillman
Copy link
Contributor

@jarrodmillman jarrodmillman commented Nov 3, 2022

I missed a few places where NumPy requirements are set. See #6607 for more details.

Description

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

I missed a few places where NumPy requirements are set.
@jarrodmillman jarrodmillman added this to the 0.20 milestone Nov 3, 2022
@stefanv stefanv merged commit e68ff34 into scikit-image:main Nov 3, 2022
@jarrodmillman jarrodmillman deleted the numpy-req branch November 17, 2022 01:22
@lagru lagru added 🔧 type: Maintenance Refactoring and maintenance of internals 🤖 type: Infrastructure CI, packaging, tools and automation and removed 🤖 type: Infrastructure CI, packaging, tools and automation labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants