-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added regression_MWI_score function #408
Added regression_MWI_score function #408
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 39 39
Lines 4616 4896 +280
Branches 487 801 +314
==========================================
+ Hits 4616 4896 +280 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Carl-McBride-Ellis for this PR. We hope to soon make a release of this new metric so it can be used in the Kaggle competition!
Note that we will need to add this change to the history and authors file.
We should definitely add some documentation, but we can do this in a separate PR, so this is pushed through as quickly as possible! New issue: #415. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Carl-McBride-Ellis for this PR! It is something that we have wanted to add for a long time.
I have just added a few comments in order to be consistent with the rest of the library
Description
This is an efficient implementation for calculating the mean Winkler interval score, based on the code written by Kaggle user AmbrosM and published in the topic "Accelerating the scoring function".
Fixes #407
Type of change
How Has This Been Tested?
Private testing was performed in the Kaglge competition Prediction interval competition I: Birth weight by comparing correspondence with the results to those output by the competition metric code published in Winkler Interval score metric.
Update (2024-02-27)
A test routine for the function
regression_MWI_score
has been written and added to the end ofmapie/tests/test_metrics.py
(b101cb0).Checklist
make lint
make type-check
make tests
make coverage
make doc