Skip to content

FIX Avoid unexpected error in make_column_transformer when columns is pandas Index #12704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2018
Merged

FIX Avoid unexpected error in make_column_transformer when columns is pandas Index #12704

merged 4 commits into from
Dec 3, 2018

Conversation

qinhanmin2014
Copy link
Member

Fixes #12703

@qinhanmin2014 qinhanmin2014 added this to the 0.20.2 milestone Dec 1, 2018
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good!

Copy link
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

......................

- |Fix| Fixed an issue in :func:`compose.make_column_transformer` which raises
unexpected error when columns is pandas Index or pandas Series.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use `pandas.Index` and it will be linked, if we like.

@jnothman jnothman merged commit aae4e33 into scikit-learn:master Dec 3, 2018
@qinhanmin2014 qinhanmin2014 deleted the columntransformer-error branch December 8, 2018 14:02
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants