Skip to content

Conversation

marenwestermann
Copy link
Member

Reference Issues/PRs

Towards #14216

What does this implement/fix? Explain your changes.

Changes the names on the functions assert_raises_on_only_one_label and assert_raises_on_all_points_same_cluster.

Any other comments?

@rth
Copy link
Member

rth commented May 11, 2021

Thanks for the PR!

That issue was about replacing all the assert_ unittest functions. Manually defined function named assert_* as in this example are fine and don't need renaming. The previous names are more explicit, as those functions indeed "assert that an exception is raised" and do not "raise exceptions".

So I'm going to close this PR sorry.

@rth rth closed this May 11, 2021
@marenwestermann marenwestermann deleted the test_unsupervised branch May 18, 2021 18:51
@marenwestermann
Copy link
Member Author

No worries, thank you for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants