Skip to content

Conversation

Hashcode-Ankit
Copy link
Contributor

Reference Issues/PRs

Addresses #21350
What does this implement/fix? Explain your changes.

Fix the description of sklearn.datasets._samples_generator.make_checkerboard

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@@ -1828,17 +1827,15 @@ def make_checkerboard(
cols : ndarray of shape (n_clusters, X.shape[1])
The indicators for cluster membership of each column.

See Also
--------
make_biclusters : Generate an array with constant block diagonal structure for biclustering.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a linting error on the CI.

Suggested change
make_biclusters : Generate an array with constant block diagonal structure for biclustering.
make_biclusters : Generate an array with constant block diagonal structure
for biclustering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure sir

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The failing test is unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants