-
-
Notifications
You must be signed in to change notification settings - Fork 25.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project_urls to setup #13623
Add project_urls to setup #13623
Conversation
Just curious, how does pypi know which icon to use with the project_urls? For example: https://pypi.org/project/Django/ and https://pypi.org/project/Flask/ have different keys for their bug tracker and source, but pypi is able to figure out which icon to use. Is pypi parsing the url? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick but LGTM
These are used by PyPI and other services.
2f6cdad
to
07df407
Compare
Here is what Flask did:
Here is what Django did:
According to the documentation (https://setuptools.readthedocs.io/en/latest/setuptools.html):
Since I wasn't sure how well PyPI would be able to guess what I meant by a term I arbitrarily made up, I just copied the example in the documentation:
|
@thomasjpfan I think PyPI has a hard coded logo for the bug tracker (since it's the same for Jango and Flask while they're using different platforms), and it recognizes github repos for the source as a special thing. Or it might just be using the favicon. |
Thanks @jarrodmillman ! |
This reverts commit f3d3203.
This reverts commit f3d3203.
These are used by PyPI and other services.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?