Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare media tutorial for characteristic impedance implementation change #888

Merged
merged 14 commits into from
Apr 13, 2023
Merged

Prepare media tutorial for characteristic impedance implementation change #888

merged 14 commits into from
Apr 13, 2023

Conversation

mhuser
Copy link
Collaborator

@mhuser mhuser commented Apr 10, 2023

Update the Media tutorial to show how the port and characteristic impedance of Media should be handled and describe use cases with figures.

@github-actions github-actions bot added the Documentation Request/Improvement of the documentation label Apr 10, 2023
@github-actions github-actions bot removed the Media label Apr 10, 2023
@mhuser mhuser linked an issue Apr 10, 2023 that may be closed by this pull request
Creating a line with characteristic impedance of the media is confusing #651
Closed
@mhuser mhuser marked this pull request as ready for review April 10, 2023 23:00
@denzchoe
Copy link
Contributor

wow these illustrations are impressive man...

jhillairet
jhillairet reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@jhillairet jhillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tutorial.

I wonder if we should drop the embed deprecation from the next release.

doc/source/tutorials/Media.ipynb Show resolved Hide resolved
@mhuser mhuser merged commit d1bb10b into scikit-rf:master Apr 13, 2023
10 checks passed
@jhillairet jhillairet mentioned this pull request May 6, 2023
Merged
@mhuser mhuser deleted the media-doc branch February 3, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

Assignees
No one assigned
Labels
Documentation Request/Improvement of the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a line with characteristic impedance of the media is confusing
3 participants
@mhuser @denzchoe @jhillairet